Skip to content

fix: sketchbook container building #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix: sketchbook container building #1814

merged 1 commit into from
Jan 17, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Jan 10, 2023 •
edited
Loading

Motivation

To fix the sketchbook folder structure in IDE2: File > Sketchbook

Change description

I completely rewrote the logic. The best is to verify with the test sketchbook IDE2 uses: __test_sketchbook__.

From now on, IDE2 gracefully handles when the sketchbook location is a sketch folder.

In action:

1185.mp4

Other information

Closes #1185

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos marked this pull request as ready for review January 11, 2023 09:14
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 11, 2023
fix: sketchbook container building
ffd1455 
Closes #1185

Signed-off-by: Akos Kitta <[email protected]>
per1234
per1234 approved these changes Jan 15, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit 692f29f into main Jan 17, 2023
@kittaakos kittaakos deleted the #1185 branch January 17, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Sketchbook" menu only 1 folder deep
2 participants
@kittaakos @per1234